Jackie-Jiang commented on code in PR #9092:
URL: https://github.com/apache/pinot/pull/9092#discussion_r931675829


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java:
##########
@@ -107,6 +107,8 @@ enum MetadataKey {
     NUM_SEGMENTS_PROCESSED("numSegmentsProcessed", MetadataValueType.INT),
     NUM_SEGMENTS_MATCHED("numSegmentsMatched", MetadataValueType.INT),
     NUM_CONSUMING_SEGMENTS_QUERIED("numConsumingSegmentsQueried", 
MetadataValueType.INT),
+    NUM_CONSUMING_SEGMENTS_PROCESSED("numConsumingSegmentsProcessed", 
MetadataValueType.INT),

Review Comment:
   (MAJOR) Please revert this PR, and re-check it in after it passes the 
compatibility test. We cannot add `MetadataKey` in the middle because we use 
ordinal to encode the key. See the comment of this enum



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to