ravishankar15 commented on code in PR #9092:
URL: https://github.com/apache/pinot/pull/9092#discussion_r928796607
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -65,13 +68,24 @@ public static void
setExecutionStatistics(IntermediateResultsBlock resultsBlock,
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
+ try {
Review Comment:
@snleee I am not sure if we can remove that for queries with limit 0 like
`SELECT * FROM testTable LIMIT 0` we are passing EmptySelectionOperator
Instance in there which does not implement the getIndexSegment() hence there
will be an exception we have a explicit test case to prevent that
`SelectionCombineOperatorTest.testSelectionLimit0` Since we are using the
interface (Operator) to reference in the for loop and interface has explicit
check to throw the exception I think it is better to enclose it within the try
catch block.
Also is the regression failing because of this try catch ? I could not see
any logs associated with the same ? Can you please help me understand the
failure so that I can fix the issue. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
