saurabhd336 commented on PR #8961: URL: https://github.com/apache/pinot/pull/8961#issuecomment-1195533920
After further testing and discussions, came to realise that people generally move to no dictionary columns if they see high dictionary sizes. Introducing a hasSet to store unique values even for non dictionary columns, just to be able to support bloom filter (This PR was using the set just to provide the cardinality value when creating bloom filter) will be counterproductive. I'm closing this PR. Will rethink and raise a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
