siddharthteotia commented on code in PR #8961:
URL: https://github.com/apache/pinot/pull/8961#discussion_r919477142


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/datasource/ImmutableDataSource.java:
##########
@@ -104,6 +104,12 @@ public Comparable getMaxValue() {
       return _maxValue;
     }
 
+    @Nullable
+    @Override
+    public Set<Comparable> getUniqueValueSet() {

Review Comment:
   May be we can see if the `DataSource` interface change can be avoided esp if 
this is applicable only to mutable ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to