siddharthteotia commented on PR #9078: URL: https://github.com/apache/pinot/pull/9078#issuecomment-1194707726
@Jackie-Jiang @somandal I think we are on the same page here w.r.t what is the end state here -- block any MV expressions in ORDER BY via throwing exception in `SelectionOrderByOperator` constructor. I am not comfortable with making a change that may fail existing queries. Shall we do this ? - Merge this change along with another change to detect presence of queries belonging to 2nd category (in my comment above) via a metric. - Follow up in a couple of weeks time after having changed user queries (if any) depending on metric we observe internally and make the change in SelectionOrderByOperator for the general scenario. I am also ok with not doing this change at all and just do the metric change since when the final solution is implemented, the current change will probably be deleted anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
