walterddr commented on PR #9078: URL: https://github.com/apache/pinot/pull/9078#issuecomment-1191862773
> Good catch! I'd suggest doing it slightly different which can handle more general cases: > > 1. In `MinMaxValueBasedSelectionOrderByCombineOperator.MinMaxValueContext`, check if `dataSourceMetadata.isSingleValue()` and put `null` if it is not single valued so that we don't get exception > 2. In `SelectionOrderByOperator.getComparator()`, we have access to the actual metadata of the transformed result, and we may perform the check if we don't want MV to be ordered (currently it skips MV expressions, but IMO it is okay to throw exception to prevent unexpected behavior) +1 on both suggestions. from this claim: > The position of the MV column has no affect on the actual ordering of results as the SelectionOrderByOperator only includes the SV columns in the comparator used to set the values in the PriorityQueue maintained by it. The query execution failure only occurs when the MV column is the first expression. I think we should definitely not allow MV values present in the order-by list with explicit error, and we can do that in the parser level already right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
