nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r929323485
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/SVScanDocIdIterator.java:
##########
@@ -188,6 +206,33 @@ public int matchValues(int limit, int[] docIds) {
}
}
+ private class DictIdMatcherAndNullHandler implements ValueMatcher {
+
+ private final int[] _buffer = new int[OPTIMAL_ITERATOR_BATCH_SIZE];
+ private final ImmutableRoaringBitmap _nullBitmap;
+
+ public DictIdMatcherAndNullHandler(ImmutableRoaringBitmap nullBitmap) {
+ _nullBitmap = nullBitmap;
+ }
+
+ @Override
+ public boolean doesValueMatch(int docId) {
+ if (_nullBitmap.contains(docId)) {
+ return false;
+ }
+ return _predicateEvaluator.applySV(_reader.getDictId(docId,
_readerContext));
+ }
+
+ @Override
+ public int matchValues(int limit, int[] docIds) {
+ _reader.readDictIds(docIds, limit, _buffer, _readerContext);
Review Comment:
Removed from this PR to simplify as you suggested. Will address in separate
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
