nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r929176335
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function
thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 &&
functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
Count(*) has no operands. Since I allow now count(colName), I removed the if
in lines 84-88 and add this if here instead.
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function
thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 &&
functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
`Count(*)` has no operands. Since I allow now `count(colName)`, I removed
the if in lines 84-88 and add this if here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
