gortiz commented on code in PR #9012:
URL: https://github.com/apache/pinot/pull/9012#discussion_r921925967


##########
kubernetes/helm/pinot/values.yaml:
##########
@@ -305,7 +311,10 @@ server:
     nodePort: ""
     protocol: TCP
 
-  resources: {}
+  resources:
+    requests:
+      cpu: "2000m"
+      memory: "1.25Gi"

Review Comment:
   I understand that they are quite different, but these resource requests have 
been decided taking into account the Xmx and GC that is being used. As all 
broker, controllers and servers use the same Xmx (1G) and the same GC (G1) then 
all of them have the same requests.
   
   I may make sense to change the default JAVA_OPTS for each service, but I 
think that is out of the scope of this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to