ankitsultana commented on code in PR #8980: URL: https://github.com/apache/pinot/pull/8980#discussion_r910310947
########## pinot-tools/src/main/java/org/apache/pinot/tools/MultistageEngineQuickStart.java: ########## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.tools; + +import com.google.common.base.Preconditions; +import com.google.common.collect.Lists; +import java.io.File; +import java.net.URL; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.commons.io.FileUtils; +import org.apache.pinot.tools.admin.PinotAdministrator; +import org.apache.pinot.tools.admin.command.QuickstartRunner; + + +public class MultistageEngineQuickStart extends QuickStartBase { + + @Override + public List<String> types() { + return Collections.singletonList("MULTI_STAGE"); + } + + @Override + public Map<String, Object> getConfigOverrides() { + Map<String, Object> overrides = new HashMap<>(super.getConfigOverrides()); + overrides.put("pinot.multistage.engine.enabled", "true"); + overrides.put("pinot.server.instance.currentDataTableVersion", 4); + return overrides; + } + + public void execute() + throws Exception { + File quickstartTmpDir = new File(_dataDir, String.valueOf(System.currentTimeMillis())); + + // Baseball stat table Review Comment: Will this Quickstart only have 1 table? Are you planning to add another table so we can demo the join functionality using the quickstart? Also, I will be adding some Uber themed use-case (with new datasets) in the table-group Quickstart. I think it would make sense to merge my Quickstart with this one.. I can take that up in a future PR. Lmk your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
