walterddr commented on code in PR #8980:
URL: https://github.com/apache/pinot/pull/8980#discussion_r910146031
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -23,13 +23,13 @@
*/
public class QueryConfig {
public static final String KEY_OF_QUERY_SERVER_PORT =
"pinot.query.server.port";
- public static final int DEFAULT_QUERY_SERVER_PORT = -1;
+ public static final int DEFAULT_QUERY_SERVER_PORT = 0;
public static final String KEY_OF_QUERY_RUNNER_HOSTNAME =
"pinot.query.runner.hostname";
public static final String DEFAULT_QUERY_RUNNER_HOSTNAME = "localhost";
// query runner port is the mailbox port.
public static final String KEY_OF_QUERY_RUNNER_PORT =
"pinot.query.runner.port";
- public static final int DEFAULT_QUERY_RUNNER_PORT = -1;
+ public static final int DEFAULT_QUERY_RUNNER_PORT = 0;
Review Comment:
i am not sure this is the right solution b/c runner ports are not specific
to the server or broker.
intermediate query runners can run on either broker or server, we just
happened to only utilize the server component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
