[GitHub] [pinot] richardstartin commented on a diff in pull request #8893: Optimize like to regexp conversion to do not include unnecessary ^.* and .*$

[GitBox]

richardstartin commented on code in PR #8893:
URL: https://github.com/apache/pinot/pull/8893#discussion_r897782788


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##########
@@ -33,7 +33,16 @@ private RegexpPatternConverterUtils() {
    * Converts a LIKE pattern into REGEXP_LIKE pattern.
    */
   public static String likeToRegexpLike(String likePattern) {
-    return "^" + escapeMetaCharacters(likePattern).replace('_', 
'.').replace("%", ".*") + "$";
+    String converted = "^" + escapeMetaCharacters(likePattern).replace('_', 
'.').replace("%", ".*") + "$";

Review Comment:
   I suggest using a StringBuilder for the intermediate operations and checks 
here and then turn it into a string at the end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org