gortiz opened a new pull request, #8893: URL: https://github.com/apache/pinot/pull/8893
`RegexpPatternConverterUtils.likeToRegexpLike` is used to translate `LIKE` expressions to `regexp_match`. The transformation is trivial, but there are some very easy optimizations that can be done. For example: As `regexp_match` has the Java Matcher.find semantics, it doesn't try to match the expression with the whole string but looks for a substring that matches the expression. Therefore, the prefix `^.*` and the suffix `.*$` are useless. This PR removes them. The PR doesn't include benchmarks that proves that the optimization is useful, but that was discovered in https://github.com/apache/pinot/pull/8818. The commit of this PR has been cherry picked from there and the benchmarks included in 8818 indicata 2x performance increase. Actual numbers can be seen here https://github.com/apache/pinot/pull/8818#issuecomment-1155165270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
