saurabhd336 commented on code in PR #8828:
URL: https://github.com/apache/pinot/pull/8828#discussion_r896971986
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2159,7 +2159,7 @@ public void refreshSegment(String tableNameWithType,
SegmentMetadata segmentMeta
sendSegmentRefreshMessage(tableNameWithType, segmentName, true, true);
}
- public int reloadAllSegments(String tableNameWithType, boolean
forceDownload) {
+ public Pair<Integer, String> reloadAllSegments(String tableNameWithType,
boolean forceDownload) {
Review Comment:
Ack. I'm planning to add it post getting a general agreement on the approach
with all segments APIs first. Is that okay?
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -245,7 +245,7 @@ public void reloadSegment(String tableNameWithType, String
segmentName, boolean
}
@Override
- public void reloadAllSegments(String tableNameWithType, boolean
forceDownload,
+ public void reloadAllSegments(String taskId, String tableNameWithType,
boolean forceDownload,
Review Comment:
Ack. I'm planning to add it post getting a general agreement on the approach
with all segments APIs first. Is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
