saurabhd336 commented on code in PR #8828:
URL: https://github.com/apache/pinot/pull/8828#discussion_r893072567
##########
pinot-common/src/main/java/org/apache/pinot/common/messages/SegmentReloadMessage.java:
##########
@@ -35,6 +35,9 @@ public class SegmentReloadMessage extends Message {
private static final String FORCE_DOWNLOAD_KEY = "forceDownload";
+ // todo (saurabh) : getMsgId() returns different id on the server side than
the one being set at controller. Check
Review Comment:
Yeah the getMsgId does fetch the record's zk id but for some reason I was
seeing this difference on server and controller side. I'll look into this more
and update the PR accordingly if we are able to use msgId itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
