jasperjiaguo commented on code in PR #8434:
URL: https://github.com/apache/pinot/pull/8434#discussion_r888552734
##########
pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java:
##########
@@ -120,6 +120,6 @@ public static InstanceAssignmentConfig
getInstanceAssignmentConfig(TableConfig t
replicaGroupStrategyConfig.getNumInstancesPerPartition(), 0, 0,
minimizeDataMovement);
}
- return new InstanceAssignmentConfig(tagPoolConfig, null,
replicaGroupPartitionConfig);
+ return new InstanceAssignmentConfig(tagPoolConfig, null,
replicaGroupPartitionConfig, null);
Review Comment:
Agreed, we can keep it in `instanceAssignmentConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
