[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #8434: [WIP][Not Ready for Review]Add replica group based instance assigment algorithm with FD awareness

[GitBox]

jasperjiaguo commented on code in PR #8434:
URL: https://github.com/apache/pinot/pull/8434#discussion_r888545405


##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java:
##########
@@ -349,7 +354,7 @@ public void testPoolBased() {
         new InstanceReplicaGroupPartitionConfig(true, 0, numReplicaGroups, 0, 
0, 0, false);
     TableConfig tableConfig = new 
TableConfigBuilder(TableType.OFFLINE).setTableName(RAW_TABLE_NAME)
         
.setInstanceAssignmentConfigMap(Collections.singletonMap(InstancePartitionsType.OFFLINE,
-            new InstanceAssignmentConfig(tagPoolConfig, null, 
replicaPartitionConfig))).build();
+            new InstanceAssignmentConfig(tagPoolConfig, null, 
replicaPartitionConfig, null))).build();

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org