Jackie-Jiang commented on PR #8712: URL: https://github.com/apache/pinot/pull/8712#issuecomment-1128041020
@richardstartin We may also name them `getInclusiveLowerBound` and `getInclusiveUpperBound` if that is more clear. I name them `min` and `max` to be consistent with the usage in the range index, but include `inclusive` explicitly in the getter could be more clear. We should try to keep the behavior consistent to avoid bugs if developer doesn't read the implementation and assume the behavior from the method signature or the javadoc. Currently it is very easy to make mistake if someone tries to add the range index support for big-decimal because that one does not return inclusive bound but has the same signature as other data types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
