walterddr commented on code in PR #8670:
URL: https://github.com/apache/pinot/pull/8670#discussion_r870867684


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -103,7 +105,7 @@ public synchronized void init(PinotConfiguration config, 
HelixManager helixManag
     _instanceId = _instanceDataManagerConfig.getInstanceId();
     _helixManager = helixManager;
     _serverMetrics = serverMetrics;
-    _authToken = 
config.getProperty(CommonConstants.Server.CONFIG_OF_AUTH_TOKEN);
+    _authProvider = AuthProviderUtils.extractAuthProvider(config, 
CommonConstants.Server.CONFIG_OF_AUTH);

Review Comment:
   totally agree. we can probably hoist it up by tagging init() method as 
deprecated and create one with the auth provider passed in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to