apucher commented on code in PR #8670:
URL: https://github.com/apache/pinot/pull/8670#discussion_r870862898
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AbstractBaseAdminCommand.java:
##########
@@ -125,34 +129,44 @@ Map<String, Object> readConfigFromFile(String
configFileName)
}
/**
- * Generate an (optional) HTTP Authorization header given an auth token
- * @see HttpClient#makeAuthHeader(String)
+ * Generate an (optional) HTTP Authorization header given an auth config
*
- * @param authToken auth token
- * @return list of 0 or 1 "Authorization" headers
+ * @param authProvider auth provider
+ * @return list of headers
*/
- static List<Header> makeAuthHeader(String authToken) {
- return HttpClient.makeAuthHeader(authToken);
+ static List<Header> makeAuthHeaders(AuthProvider authProvider) {
+ return AuthProviderUtils.toRequestHeaders(authProvider);
}
/**
* Generate auth token from pass-thru token or generate basic auth from
user/password pair
*
+ * @param provider optional provider
+ * @param tokenUrl optional token url
* @param authToken optional pass-thru token
* @param user optional username
* @param password optional password
* @return auth token, or null if neither pass-thru token nor user info
available
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
