[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8669: Change minion's default port, enable minion health and readiness probe via helm chart

[GitBox]

Jackie-Jiang commented on code in PR #8669:
URL: https://github.com/apache/pinot/pull/8669#discussion_r870622462


##########
pinot-tools/src/main/resources/conf/pinot-minion.conf:
##########
@@ -33,7 +33,7 @@ pinot.set.instance.id.to.hostname=true
 # pinot.minion.host=localhost
 
 # Pinot Minion Port
-pinot.minion.port=8098
+pinot.minion.port=9154

Review Comment:
   ```suggestion
   pinot.minion.port=9514
   ```



##########
pinot-tools/src/main/resources/conf/pinot-minion.conf:
##########
@@ -33,7 +33,7 @@ pinot.set.instance.id.to.hostname=true
 # pinot.minion.host=localhost
 
 # Pinot Minion Port
-pinot.minion.port=8098
+pinot.minion.port=9154
 
 # Pinot Minion Admin API Port
 pinot.minion.adminapi.port=6500

Review Comment:
   Remove this part



##########
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java:
##########
@@ -155,23 +155,14 @@ public static List<ListenerConfig> 
buildServerAdminConfigs(PinotConfiguration se
   public static List<ListenerConfig> 
buildMinionAdminConfigs(PinotConfiguration minionConf) {

Review Comment:
   (minor) to avoid confusion
   ```suggestion
     public static List<ListenerConfig> buildMinionConfigs(PinotConfiguration 
minionConf) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org