richardstartin commented on code in PR #8628:
URL: https://github.com/apache/pinot/pull/8628#discussion_r863951473
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracer.java:
##########
@@ -43,6 +43,14 @@ public interface Tracer {
*/
InvocationScope createScope(Class<?> clazz);
+ /**
+ * Starts
+ * @return the request record
+ */
+ default RequestScope createRequestScope() {
Review Comment:
Yes, you can do that, or just construct `new DefaultRequestStatistics()`,
which is the old class which has moved to `pinot-spi`, if you don't want to use
the `Tracer` SPI though this would break if you do use it and change the
implementation.
I'm surprised this is currently used as an API, so it's probably a good
thing that this is being turned into an SPI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
