siddharthteotia commented on code in PR #8628:
URL: https://github.com/apache/pinot/pull/8628#discussion_r863948002


##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracer.java:
##########
@@ -43,6 +43,14 @@ public interface Tracer {
      */
     InvocationScope createScope(Class<?> clazz);
 
+    /**
+     * Starts
+     * @return the request record
+     */
+    default RequestScope createRequestScope() {

Review Comment:
   Within our internal code that receives the query rest request and calls 
broker request handle code, we do the following
   
   ```
   RequestStatistics requestStatistics = new RequestStatistics();
   brokerRequestHandler.handleRequest(request, requesterIdentity, 
requestStatistics);
   ```
   
   I am guessing the first will be changed to following and it should continue 
to work as today ?
   
   `Tracing.getTracer().createRequestScope()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to