richardstartin commented on PR #8485: URL: https://github.com/apache/pinot/pull/8485#issuecomment-1097100108
@siddharthteotia as discussed offline, * tracing enabled means the request is being traced. If the request isn't traced, inert/no-op scopes are produced. These must be effectively free otherwise it causes problems with overhead. With this design, tracing is basically free when inactive. * recording enabled is different: even if a request isn't traced, instrumentation code needs to look the same, but when tracing is enabled, performing expensive work is justified, so `isEnabled` is a way to ask if the active scope is on or not, to avoid doing expensive work. Even when tracing is enabled, a particular implementation may not be interested in a particular piece of data, so may choose not to enable a scope. Having the checks in the instrumentation code allows disabled scopes to avoid the cost of data collection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
