richardstartin commented on PR #8485: URL: https://github.com/apache/pinot/pull/8485#issuecomment-1093114977
I’ve measured the overhead of this manual instrumentation and it is within the noise when tracing is disabled. The will however augment default tracing, adding an entry per transform and projection block evaluated. Is this acceptable? Whenever I have tried to use existing tracing I have encountered ConcurrentModificationExceptions (still broken) as well as NullPointerExceptions (fixed recently) so I assume that nobody actually uses it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
