dongxiaoman commented on PR #8506: URL: https://github.com/apache/pinot/pull/8506#issuecomment-1097077899
@mcvsubbu @jackjlli (Let me update that part in the description) 1. The fix in Helix `0.9.9` unblocks the case when the ZNode is larger than 1MB **even after compression**. The [code change in 0.9.9 is here](https://github.com/apache/helix/blame/5acf3e14c96281e3d83323f2b630efa4f474458a/helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java#L89) while the limit is applied when we [update Zookeeper nodes from the same ZkClient](https://github.com/apache/helix/blob/helix-0.9.9/helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java#L1416). It happens when the Pinot table has lots of segments with long hostnames, for IdealStates node. 2. Right now it will be awesome to have Helix 1.0+ in; if it is not catching the next release, it will be good for the community to upgrade `0.9.9` since this Helix back-port patch is actually requested by us Pinot For @Jackie-Jiang I will roll back to `0.9.9` ; mostly I found the `0.9.10` in [Maven Repo](https://mvnrepository.com/artifact/org.apache.helix/helix-core/0.9.10) so I thought it is released Let me also design an integration test case where the ZNode bug will show up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
