richardstartin commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r836710516
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/query/DictionaryBasedAggregationOperator.java
##########
@@ -44,6 +44,8 @@
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.utils.ByteArray;
+import static
org.apache.pinot.core.operator.query.AggregationOperatorUtils.toDouble;
Review comment:
I've used Google Java format a lot in the past, and it permits static
imports. Like a lot of language features (questionable uses of anonymous
classes abound in the code base) they can be abused, but they're in the
language for a reason. A blanket ban is better than debating the merits of
every single static import, of course ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
