richardstartin commented on a change in pull request #8408:
URL: https://github.com/apache/pinot/pull/8408#discussion_r836685811
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java
##########
@@ -176,11 +181,18 @@ private TransformOperator
buildTransformOperatorForFilteredAggregates(BaseFilter
BaseFilterOperator filterOperator = filterPlanNode.run();
// Use metadata/dictionary to solve the query if possible
- // TODO: Use the same operator for both of them so that COUNT(*), MAX(col)
can be optimized
Review comment:
Let me revisit this PR to unify these operators. I want to introduce a
minimal interface which `Dictionary` and `DataSource` implement. In another PR,
I completely remove the count optimisation here because it can be solved in a
simpler way...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
