richardstartin commented on pull request #8279: URL: https://github.com/apache/pinot/pull/8279#issuecomment-1059425866
> > @sajjad-moradi We rarely block a PR unless the code design is completely broken. I looked at the comments and I see that you have mentioned that most of them are subjective. > > Can you please unblock us if what you are requesting is subjective. Thanks for understanding. > > Of course. Didn't know about this convention. The PR really looks good in general. Thanks, I felt it was important to run the changes past you or @mcvsubbu as a courtesy, because you might need to debug something introduced here, but when it comes to naming (or composition vs inheritance) there tend to be as many opinions as there are people. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
