sajjad-moradi commented on a change in pull request #8279: URL: https://github.com/apache/pinot/pull/8279#discussion_r819809010
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -242,6 +235,10 @@ public long getLatestIngestionTimestamp() { // Initialize for each column for (FieldSpec fieldSpec : _physicalFieldSpecs) { String column = fieldSpec.getName(); + boolean isRaw = isNoDictionaryColumn(noDictionaryColumns, invertedIndexColumns, fieldSpec, column); Review comment: You can go either way, but IMO they're essentially the same. The method name is `isNoDictionaryColumn()`, so it's more consistent with that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org