atris commented on a change in pull request #8172:
URL: https://github.com/apache/pinot/pull/8172#discussion_r806536248



##########
File path: 
pinot-core/src/test/java/org/apache/pinot/queries/FilteredAggregationsTest.java
##########
@@ -296,6 +296,19 @@ public void testMultipleAggregationsOnSameFilter() {
         + "MAX(CASE WHEN (INT_COL > 29990) THEN INT_COL ELSE 0 END) AS 
total_max, "
         + "SUM(CASE WHEN (NO_INDEX_COL < 5000) THEN INT_COL ELSE 0 END) AS 
total_sum, "
         + "MAX(CASE WHEN (NO_INDEX_COL < 5000) THEN NO_INDEX_COL ELSE 0 END) 
AS total_max2 FROM MyTable";
+  }
+
+  @Test
+  public void testMixedAggregations() {

Review comment:
       Lets rename this to testMixedAggregationsOfSameType, since other tests 
in this class contain tests with mixed aggregations, just of different types




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to