Jackie-Jiang commented on a change in pull request #8172:
URL: https://github.com/apache/pinot/pull/8172#discussion_r803116594
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/FilteredAggregationsTest.java
##########
@@ -143,287 +139,172 @@ private void buildSegment(String segmentName)
}
}
- private void testInterSegmentAggregationQueryHelper(String firstQuery,
String secondQuery) {
- // SQL
- BrokerResponseNative firstBrokerResponseNative =
getBrokerResponseForSqlQuery(firstQuery);
- BrokerResponseNative secondBrokerResponseNative =
getBrokerResponseForSqlQuery(secondQuery);
- ResultTable firstResultTable = firstBrokerResponseNative.getResultTable();
- ResultTable secondResultTable =
secondBrokerResponseNative.getResultTable();
- DataSchema firstDataSchema = firstResultTable.getDataSchema();
- DataSchema secondDataSchema = secondResultTable.getDataSchema();
-
- Assert.assertEquals(firstDataSchema.size(), secondDataSchema.size());
-
- List<Object[]> firstSetOfRows = firstResultTable.getRows();
- List<Object[]> secondSetOfRows = secondResultTable.getRows();
-
- Assert.assertEquals(firstSetOfRows.size(), secondSetOfRows.size());
-
- for (int i = 0; i < firstSetOfRows.size(); i++) {
- Object[] firstSetRow = firstSetOfRows.get(i);
- Object[] secondSetRow = secondSetOfRows.get(i);
-
- Assert.assertEquals(firstSetRow.length, secondSetRow.length);
-
- for (int j = 0; j < firstSetRow.length; j++) {
- //System.out.println("FIRST " + firstSetRow[j] + " SECOND " +
secondSetRow[j] + " j " + j);
- Assert.assertEquals(firstSetRow[j], secondSetRow[j]);
- }
+ private void testQuery(String filterQuery, String nonFilterQuery) {
+ List<Object[]> filterQueryResults =
getBrokerResponseForSqlQuery(filterQuery).getResultTable().getRows();
Review comment:
Added the data schema check in #8184
The rows check remains the same, where `assertEquals(Object[] a, Object[]
b)` will verify the array size and array content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
