Jackie-Jiang commented on pull request #8170: URL: https://github.com/apache/pinot/pull/8170#issuecomment-1035226449
@hristo-stripe There are multiple cases where pinot can give approximate results for group-by queries: - Within segment, `numGroupsLimitReached` means new groups are ignored, which can potentially cause very inaccurate results in certain cases such as the group-by column is sorted - Trimming groups based on the ORDER-BY clause, which can remove the tail groups, and should give very close approximation if not 100% accurate. We should notify the user about the first case because that can result in very inaccurate results. For the second case, since it usually gives very close approximation, we don't want to mix it with the first case. If necessary, we can add another flag for the second case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
