Jackie-Jiang commented on pull request #8170: URL: https://github.com/apache/pinot/pull/8170#issuecomment-1034295782
We don't use `numGroupsLimitReached` to mark the trimming process. `numGroupsLimitReached` should be set when the `GroupByExecutor` has reached the groups limit, and no longer accepting new groups. The difference is that, during the trimming process, we don't blindly drop groups, but order the groups based on the ORDER BY clause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
