richardstartin commented on a change in pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#discussion_r800106387



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -109,12 +111,11 @@ public int getNumDocs() {
    * @return Array of int values
    */
   public int[] getIntValuesForSVColumn(String column) {
-    ColumnTypePair key = new ColumnTypePair(column, FieldSpec.DataType.INT);

Review comment:
       Exactly, about 8MB of these were allocated in 1s in a benchmark which 
only allocated ~25MB/s. It's one of the main sources of allocation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to