siddharthteotia commented on a change in pull request #8140:
URL: https://github.com/apache/pinot/pull/8140#discussion_r800105038
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -109,12 +111,11 @@ public int getNumDocs() {
* @return Array of int values
*/
public int[] getIntValuesForSVColumn(String column) {
- ColumnTypePair key = new ColumnTypePair(column, FieldSpec.DataType.INT);
- int[] intValues = (int[]) _valuesMap.get(key);
Review comment:
Previously there is a single level indirection to get the corresponding
values[] for a given `ColumnTypePar`. Now it's a `Map<Type,Map<String,Object>>`
plus another function call getValues().
So while we avoid the creation of ColumnTypePair object, is it possible that
new code will add some perf overhead that will negate any benefit of this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
