[GitHub] [pinot] mqliang commented on a change in pull request #8137: do not identify function types by throwing exceptions

[GitBox]

mqliang commented on a change in pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#discussion_r800101335



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionDefinitionRegistry.java
##########
@@ -29,20 +29,10 @@ private FunctionDefinitionRegistry() {
   }
 
   public static boolean isAggFunc(String functionName) {
-    try {
-      AggregationFunctionType.getAggregationFunctionType(functionName);
-      return true;
-    } catch (IllegalArgumentException e) {
-      return false;
-    }
+    return AggregationFunctionType.isAggregationFunction(functionName);
   }
 
   public static boolean isTransformFunc(String functionName) {
-    try {
-      TransformFunctionType.getTransformFunctionType(functionName);
-      return true;
-    } catch (IllegalArgumentException e) {
-      return false;
-    }
+    return TransformFunctionType.isTransformFunction(functionName);

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org