mqliang commented on a change in pull request #8137:
URL: https://github.com/apache/pinot/pull/8137#discussion_r800101265
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionDefinitionRegistry.java
##########
@@ -29,20 +29,10 @@ private FunctionDefinitionRegistry() {
}
public static boolean isAggFunc(String functionName) {
Review comment:
This function looks like just an alias of
`AggregationFunctionType.isAggregationFunction`. Can we just remove it and let
caller to call `AggregationFunctionType.isAggregationFunction` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
