richardstartin commented on a change in pull request #8083:
URL: https://github.com/apache/pinot/pull/8083#discussion_r796150428
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
##########
@@ -81,10 +83,11 @@ public ServerChannels(QueryRouter queryRouter,
BrokerMetrics brokerMetrics, TlsC
}
public void sendRequest(String rawTableName, AsyncQueryResponse
asyncQueryResponse,
- ServerRoutingInstance serverRoutingInstance, InstanceRequest
instanceRequest)
+ ServerRoutingInstance serverRoutingInstance, InstanceRequest
instanceRequest, long timeoutMs)
throws Exception {
+ byte[] requestBytes = _serializer.serialize(instanceRequest);
Review comment:
yes, this is a very good change, I expect to find that this will
significantly improve broker scalability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
