richardstartin commented on pull request #8083: URL: https://github.com/apache/pinot/pull/8083#issuecomment-1023922099
> > The problem with manual instrumentation like this is every Pinot user has to pay for it whether they want to use it or not. > > How about time-out when waiting lock but does not emit metric? In this way, it will not bring overhead for "happy path". > > * for "happy" queries, they will acquire the lock before the time-out, no overhead for them > * for "unhappy" queries, they will get an interruption from timer when time-out elapsed, then remove themself from the lock waiting queue I'm OK with the change itself, I just don't like the metric 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
