dianaarnos commented on a change in pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#discussion_r787729991
##########
File path: kubernetes/helm/pinot/templates/controller/ingress.yaml
##########
@@ -0,0 +1,30 @@
+{{- if .Values.controller.ingress.enabled -}}
+{{- $ingressPath := .Values.controller.ingress.path -}}
+{{- $serviceName := include "pinot.controller.fullname" . -}}
+{{- $servicePort := .Values.controller.service.port -}}
+apiVersion: extensions/v1beta1
Review comment:
@xiangfu0 as commented on Slack, the project wants to
>catch up with most the cloud vendors. So far the lowest version is 1.18.16
from Amazon EKS
And `extensions/v1beta1` is supported out of the box from 1.18 forward while
`networking.k8s.io/v1` is supported from `1.19`. I guess we want to keep it as
`extensions/v1beta1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
