WyriHaximus commented on a change in pull request #7997: URL: https://github.com/apache/pinot/pull/7997#discussion_r785208181
########## File path: kubernetes/helm/pinot/templates/controller/ingress.yaml ########## @@ -0,0 +1,30 @@ +{{- if .Values.controller.ingress.enabled -}} +{{- $ingressPath := .Values.controller.ingress.path -}} +{{- $serviceName := include "pinot.controller.fullname" . -}} +{{- $servicePort := .Values.controller.service.port -}} +apiVersion: extensions/v1beta1 +kind: Ingress +metadata: + name: {{ include "pinot.controller.fullname" . }} +{{- if .Values.controller.ingress.annotations }} + annotations: +{{ toYaml .Values.controller.ingress.annotations | indent 4 }} + {{- end }} + labels: + {{- include "pinot.controllerLabels" . | nindent 4 }} +spec: +{{- if .Values.controller.ingress.tls }} + tls: +{{ toYaml .Values.controller.ingress.tls | indent 4 }} +{{- end }} + rules: + {{- range .Values.controller.ingress.hosts }} + - host: {{ . }} + http: + paths: + - path: {{ $ingressPath }} + backend: + serviceName: {{ $serviceName }} Review comment: @dianaarnos This is exactly why I suggested asking about the minimum supported version of Kubernetes. The version we build together is an older version then is now the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org