klsince commented on a change in pull request #8035:
URL: https://github.com/apache/pinot/pull/8035#discussion_r787239142
##########
File path:
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java
##########
@@ -1115,6 +1116,18 @@ private void testIfNeedProcess()
assertFalse(processor.needProcess());
}
+ // No preprocessing needed if required to add certain index on
non-existing, sorted or non-dictionary column.
+ for (Consumer<IndexLoadingConfig> prepFunc :
createConfigPrepFunctionNeedNoops()) {
Review comment:
didn't use DataProvider but a simple Map to provide the test cases, as
the test cases are checked both individually and used to load up a temp config
upfront. But anyway, I added test name to assertions for easy debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
