npawar commented on a change in pull request #8035:
URL: https://github.com/apache/pinot/pull/8035#discussion_r787093993
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/FSTIndexHandler.java
##########
@@ -79,8 +79,24 @@ public FSTIndexHandler(SegmentMetadata segmentMetadata,
IndexLoadingConfig index
@Override
public boolean needUpdateIndices(SegmentDirectory.Reader segmentReader) {
+ String segmentName = _segmentMetadata.getName();
Set<String> existingColumns =
segmentReader.toSegmentDirectory().getColumnsWithIndex(ColumnIndexType.FST_INDEX);
- return !existingColumns.equals(_columnsToAddIdx);
+ // Check if any existing index need to be removed.
+ for (String column : existingColumns) {
+ if (!_columnsToAddIdx.remove(column)) {
+ LOGGER.debug("Need to remove existing FST index from segment: {},
column: {}", segmentName, column);
+ return true;
+ }
+ }
+ // Check if any new index need to be added.
+ for (String column : _columnsToAddIdx) {
+ ColumnMetadata columnMetadata =
_segmentMetadata.getColumnMetadataFor(column);
+ if (columnMetadata != null) {
Review comment:
if any of the checks in `checkUnsupportedOperationsForFSTIndex` fail, we
would have simply copied the segment, only to throw exception. How about
checking those here as well (by sharing the method) and failing here itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
