Jackie-Jiang commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r787204527
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ########## @@ -85,6 +85,7 @@ // Keep the BrokerRequest to make incremental changes // TODO: Remove it once the whole query engine is using the QueryContext private final BrokerRequest _brokerRequest; + private QueryContext _preAggregateGapFillQueryContext; Review comment: @siddharthteotia From query syntax perspective, I don't see difference between pre-aggregate-gap-fill and general subquery. Essentially the `FROM` clause contains a query instead of a table name. I'd suggest adding it as general subquery, but we can support it in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org