weixiangsun commented on a change in pull request #8029: URL: https://github.com/apache/pinot/pull/8029#discussion_r785603812
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BlockValSetImpl.java ########## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.reduce; + +import java.util.List; +import javax.annotation.Nullable; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.segment.spi.index.reader.Dictionary; +import org.apache.pinot.spi.data.FieldSpec; + + +/** + * Helper class to convert the result rows to BlockValSet. + */ +@SuppressWarnings({"rawtypes", "unchecked"}) +public class BlockValSetImpl implements BlockValSet { + + private final FieldSpec.DataType _dataType; + private final List<Object[]> _rows; + private final int _columnIndex; + + public BlockValSetImpl(DataSchema.ColumnDataType columnDataType, List<Object[]> rows, int columnIndex) { + _dataType = columnDataType.toDataType(); + _rows = rows; + _columnIndex = columnIndex; + } + + @Override + public FieldSpec.DataType getValueType() { + return _dataType; + } + + @Override + public boolean isSingleValue() { + return true; + } + + @Nullable + @Override + public Dictionary getDictionary() { + throw new UnsupportedOperationException("Not supported"); + } + + @Override + public int[] getDictionaryIdsSV() { + throw new UnsupportedOperationException("Not supported"); + } + + @Override + public int[] getIntValuesSV() { + if (_dataType == FieldSpec.DataType.INT) { + int [] result = new int[_rows.size()]; + for (int i = 0; i < result.length; i++) { + result[i] = (Integer) _rows.get(i)[_columnIndex]; + } + return result; + } + throw new UnsupportedOperationException("Not supported"); + } + + @Override + public long[] getLongValuesSV() { + if (_dataType == FieldSpec.DataType.LONG) { + long [] result = new long[_rows.size()]; + for (int i = 0; i < result.length; i++) { + result[i] = (Long) _rows.get(i)[_columnIndex]; + } + return result; + } + throw new UnsupportedOperationException("Not supported"); Review comment: Should we allow to cast Integer to Long or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
