atris commented on pull request #8016: URL: https://github.com/apache/pinot/pull/8016#issuecomment-1014231281
> I like the neatness of the algorithm. There are simple paths forward towards optimising it which could be made now if you want, or later if it proves necessary. > A more optimised version is here: https://github.com/atris/thunderbolt/blob/main/src/main/java/io/github/atris/thunderbolt/MutableFst.java I do not believe we need this yet, but if needed, we can optimise later. > I have two general points about the layout of the code (I don't like focussing on this sort of thing, but feel it's necessary here): > > 1. It needs to be formatted properly: https://github.com/apache/pinot/blob/master/config/codestyle-intellij.xml > 2. There are too many blank lines. In my humble opinion, these do not aid the reader at all. On many occasions I look at 15 lines of code and notice they compress to 5. It really obscures the logic by occupying screen space. Thanks for pointing that out. The problem is that my laptop is M1 Pro based, so a global build of Pinot fails on it. I am dependent on Linter checks to tell me if check style is failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
