deemoliu edited a comment on pull request #7906: URL: https://github.com/apache/pinot/pull/7906#issuecomment-1013472410
> Quick comment: the existing code does not define any default strategy for any column (eg: OVERWRITE). So instead of introducing a new property, can we simply define a default strategy (eg: within UpsertConfig). (of course null handling is still needed). CC @yupeng9 @Jackie-Jiang Hi @icefury71 thanks for the comment. Yes, there is no default strategy for columns that not specified in upsertConfig. The current behavior for columns not specified is "OVERWRITE even if the fieldValue of the new record is null". In this PR, i updated the default behavior (which is represented by "globalUpsertStrategy") to use "OVERWRITE unless the fieldValue of new record is null", which is the same behavior of the OVERWRITE merger. I think @Jackie-Jiang mentioned updating this will introduce backward incompatibility and @yupeng9 mentioned we should get the best possible default option. @icefury71 @yupeng9 @Jackie-Jiang what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
