deemoliu commented on a change in pull request #7906:
URL: https://github.com/apache/pinot/pull/7906#discussion_r783323329
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java
##########
@@ -53,21 +53,27 @@
@JsonPropertyDescription("Partial update strategies.")
private final Map<String, Strategy> _partialUpsertStrategies;
+ @JsonPropertyDescription("global upsert strategy")
+ private final Strategy _globalUpsertStrategy;
+
@JsonPropertyDescription("Column for upsert comparison, default to time
column")
private final String _comparisonColumn;
@JsonCreator
public UpsertConfig(@JsonProperty(value = "mode", required = true) Mode mode,
@JsonProperty("partialUpsertStrategies") @Nullable Map<String, Strategy>
partialUpsertStrategies,
+ @JsonProperty("globalUpsertStrategy") @Nullable Strategy
globalUpsertStrategy,
@JsonProperty("comparisonColumn") @Nullable String comparisonColumn,
@JsonProperty("hashFunction") @Nullable HashFunction hashFunction) {
Preconditions.checkArgument(mode != null, "Upsert mode must be
configured");
_mode = mode;
if (mode == Mode.PARTIAL) {
_partialUpsertStrategies = partialUpsertStrategies != null ?
partialUpsertStrategies : new HashMap<>();
+ _globalUpsertStrategy = globalUpsertStrategy != null ?
globalUpsertStrategy : Strategy.OVERWRITE;
Review comment:
Thanks @Jackie-Jiang for review. If we use Ignore
(https://github.com/apache/pinot/pull/7907) as default behavior for global
mergers, do you think it will solve the backward compatible issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
