siddharthteotia commented on a change in pull request #7972:
URL: https://github.com/apache/pinot/pull/7972#discussion_r784505678
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -147,6 +147,9 @@ static void validate(PinotQuery pinotQuery)
private static void validateGroupByClause(PinotQuery pinotQuery)
throws SqlCompilationException {
if (pinotQuery.getGroupByList() == null) {
+ if (containsAggregateAndColsInSelectClause(pinotQuery)) {
+ throw new SqlCompilationException("Columns and Aggregate functions
can't co-exist without GROUP BY clause");
+ }
return;
}
// Sanity check group by query: All non-aggregate expression in selection
list should be also included in group
Review comment:
I would suggest keeping it simple for now as outlined in my previous
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
